Skip to content

Increase Description field max character length#296

Merged
kabilar merged 3 commits intodandi:masterfrom
kabilar:description-length
Apr 30, 2025
Merged

Increase Description field max character length#296
kabilar merged 3 commits intodandi:masterfrom
kabilar:description-length

Conversation

@kabilar
Copy link
Member

@kabilar kabilar commented Apr 11, 2025 •
edited
Loading

Fix #295

10,000 characters is about 2-3 single-spaced pages. Based on the OpenScope use case, the dataset descriptions (https://openscopedatafront.web.app/datasets) will fit within 10,000 characters. See here for the context: dandi/dandi-archive#2297.

@kabilar kabilar requested a review from yarikoptic April 11, 2025 23:00
@codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (782c421) to head (cf7fbb0).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
- Coverage   97.88%   93.24%   -4.64%     
==========================================
  Files          16       16              
  Lines        1983     1983              
==========================================
- Hits         1941     1849      -92     
- Misses         42      134      +92
Flag Coverage Δ
unittests 93.24% <100.00%> (-4.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kabilar
Copy link
Member Author

kabilar commented Apr 15, 2025

@yarikoptic Not sure why the tests are failing but it appears to be unrelated.

@kabilar kabilar requested a review from candleindark April 29, 2025 20:24
candleindark
candleindark approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@candleindark candleindark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be fine. However, I think we will get a new JSON schema because of this change. In consts.py, you may want to change DANDI_SCHEMA_VERSION
to "0.6.11" and add "0.6.10" to ALLOWED_INPUT_SCHEMAS

@kabilar
Copy link
Member Author

kabilar commented Apr 29, 2025

This change should be fine. However, I think we will get a new JSON schema because of this change. In consts.py, you may want to change DANDI_SCHEMA_VERSION to "0.6.11" and add "0.6.10" to ALLOWED_INPUT_SCHEMAS

Thanks. I have now updated the DANDI_SCHEMA_VERSION.

@kabilar kabilar added the patch Increment the patch version when merged label Apr 29, 2025
@kabilar
Copy link
Member Author

kabilar commented Apr 30, 2025

Looks like these CI failures are unrelated. Merging.

@kabilar kabilar merged commit 84bef7e into dandi:master Apr 30, 2025
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candleindark candleindark candleindark approved these changes

@yarikoptic yarikoptic Awaiting requested review from yarikoptic

Assignees

No one assigned

Labels

patch Increment the patch version when merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow for more than 3,000 characters in the DLP Description field

2 participants

@kabilar @candleindark